Skip to content

refactor(svm): minimize allocations in the log collector #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 14, 2025
Merged

refactor(svm): minimize allocations in the log collector #935

merged 13 commits into from
Oct 14, 2025

Conversation

@dnut
Copy link
Contributor

@dnut dnut commented Sep 5, 2025

replaces #773 since that pr came from another repo, which is not able to merge into main

@dnut dnut requested review from ultd and yewman as code owners September 5, 2025 13:03
@github-project-automation github-project-automation bot moved this to 🏗 In progress in Sig Sep 5, 2025
@dnut dnut enabled auto-merge September 5, 2025 13:07
@codecov
Copy link

codecov bot commented Sep 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.23529% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/vm/syscalls/sysvar.zig 62.50% 3 Missing ⚠️
src/utils/allocators.zig 0.00% 2 Missing ⚠️
src/accountsdb/fuzz.zig 0.00% 1 Missing ⚠️
src/accountsdb/snapshot/download.zig 0.00% 1 Missing ⚠️
src/geyser/core.zig 0.00% 1 Missing ⚠️
src/gossip/dump_service.zig 0.00% 1 Missing ⚠️
src/gossip/service.zig 75.00% 1 Missing ⚠️
src/runtime/program/testing.zig 96.15% 1 Missing ⚠️
src/runtime/testing.zig 83.33% 1 Missing ⚠️
src/shred_network/repair_service.zig 0.00% 1 Missing ⚠️
... and 1 more
Files with missing lines Coverage Δ
src/accountsdb/buffer_pool.zig 95.09% <100.00%> (ø)
src/accountsdb/db.zig 89.23% <100.00%> (ø)
src/accountsdb/swiss_map.zig 97.04% <100.00%> (ø)
src/adapter.zig 50.00% <ø> (ø)
src/benchmarks.zig 50.00% <ø> (ø)
src/gossip/data.zig 74.57% <100.00%> (ø)
src/gossip/fuzz_service.zig 96.61% <ø> (ø)
src/net/socket_utils.zig 92.85% <100.00%> (ø)
src/prometheus/http.zig 0.00% <ø> (ø)
src/rpc/request.zig 88.18% <ø> (ø)
... and 20 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yewman
yewman previously approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@yewman yewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dnut dnut linked an issue Oct 6, 2025 that may be closed by this pull request
perf(svm): minimize LogCollector allocations #986
Closed
@dnut dnut added this pull request to the merge queue Oct 14, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig Oct 14, 2025
Merged via the queue into main with commit 50c3236 Oct 14, 2025
18 checks passed
@dnut dnut deleted the ali/log branch October 14, 2025 21:21
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Sig Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yewman yewman yewman approved these changes

@kprotty kprotty kprotty approved these changes

@ultd ultd Awaiting requested review from ultd ultd is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Sig
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

perf(svm): minimize LogCollector allocations

5 participants

@dnut @yewman @kprotty @alichraghi